PowerShell Practice and Style
Search…
Introduction
Style Guide
Readability
TODO: This section should probably be merged to Code Layout and Formatting, and based on the #15, we should remove or rewrite the backticks section.
READ-01 Indent your code
Consider this code example:
1
if ($this -gt $that) {
2
Do-Something -with $that
3
}
Copied!
And now consider this one:
1
if ($this -gt $that)
2
{
3
Do-Something -with $that
4
}
Copied!
Neither of these is better than the other. Ask 100 coders which they prefer and you'll get roughly half liking either one. Now, when you start dealing with commands that accept script blocks as parameters, things can get trickier because of the way PowerShell parses syntax. "Wrong" is wrong. With scripting constructs, like the two examples above, there's no functional difference.
Continuing in that vein, understand that the following are basically guidelines from mass consensus; they're not hard-and-fast rules. That said, there are arguments in favor of these, and you should consider the arguments before dismissing these ideas.
First, format your code properly. The convention is to indent within constructs, to make it clearer what "belongs to" the construct.
1
foreach ($computer in $computers) {
2
Do-This
3
Get-Those
4
}
Copied!
You will probably be reviled if you don't format carefully.
READ-02 Avoid backticks
Consider this:
1
Get-WmiObject -Class Win32_LogicalDisk `
2
-Filter "DriveType=3" `
3
-ComputerName SERVER2
Copied!
In general, the community feels you should avoid using those backticks as "line continuation characters" when possible. They're hard to read, easy to miss, and easy to mistype. Also, if you add an extra whitespace after the backtick in the above example, then the command won't work. The resulting error is hard to correlate to the actual problem, making debugging the issue harder.
Here's an alternative:
1
$GetWmiObjectParams = @{
2
Class = "Win32_LogicalDisk"
3
Filter = "DriveType=3"
4
ComputerName = "SERVER2"
5
}
6
Get-WmiObject @GetWmiObjectParams
Copied!
The technique is called splatting. It lets you get the same nice, broken-out formatting without using the backtick. You can also line break after almost any comma, pipe character, or semicolon without using a backtick.
The backtick is not universally hated - but it can be inconvenient. If you have to use it for line breaks, well then, use it. Just try not to have to.
Last modified 9mo ago
Copy link